Rebase of PR 1/11: @Clementguidi: dynamic: Refactor logic to perform multiple updates (dynamic runtime init) #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation of runtime dynamic patching. This commit guarantees that dynamic info is read only once for the target binary and for each module. Co-authored-by: Gabriel-Andrew Pollo-Guilbert <[email protected]> Signed-off-by: Seyed-Vahid Azhari <[email protected]>
If 'mcount_dynamic_update' is called multiple times (e.g. at runtime), it initializes the size filter only once. Signed-off-by: Clément Guidi <[email protected]>
Skip the initialization of the disassembly engine with it has already been performed. Signed-off-by: Clément Guidi <[email protected]>
The dynamic pattern list is not reused from a dynamic update to another, keeping libmcount stateless in that regard. Co-authored-by: Gabriel-Andrew Pollo-Guilbert <[email protected]> Signed-off-by: Clément Guidi <[email protected]>
The 'mcount_dynamic_update' is now safe to call multiple times, including at runtime. On each call, it will perform patching and unpatching of the target (not implemented yet). Signed-off-by: Clément Guidi <[email protected]>
Install a trampoline for each loaded module map, on initialization. Keep the trampolines in memory to allow for dynamic patching at runtime. Clear the trampolines on libmcount exit. Co-authored-by: Gabriel-Andrew Pollo-Guilbert <[email protected]> Signed-off-by: Clément Guidi <[email protected]>
Trigger architecture specific dynamic initialization when initializing the dynamic instrumentation mechanics. Co-authored-by: Gabriel-Andrew Pollo-Guilbert <[email protected]> Signed-off-by: Clément Guidi <[email protected]>
Don't save instructions if they are already present in the code hmap. Signed-off-by: Clément Guidi <[email protected]>
Commands used: gh pr checkout 1702 git switch -c new-branch git rebase master # (no warnings, no conflicts) git push Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
changed the title
|
Thanks for doing this! I'll check the code. In this case, you added some work on others. Then you need to add your own Signed-off-by line at the bottom. |
|
@namhyung: Done now, added a final commit at the bottom: |
|
I'm still seeing some test failures: |
|
@clementguidi: FYI, This would still cause regression(s), can you check? (Maybe fixed by other parts of your series? |
|
Hi @bernhardkaindl, thank you I'll have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1702 (first PR of @clementguidi's series) below rebased to the current master to hopefully fix the remaining test failures.
The description for this first PR in the series is:
I only did:
Hopefully, this fixes the remaining test failures from #1702:
Copied from the description of #1702:
This is the first PR in a series of patches intended to bring runtime dynamic tracing on x86_64 to uftrace.
#1702 🠈
#1703
#1704
#1705
#1745
#1746
#1747
#1748
#1749
#1750
#1751
First, we refactor the life cycle of dynamic structures so a dynamic update can be triggered at anytime during execution, any amount of times. This will allow the agent to call mcount_dynamic_update() multiple times at runtime.
Related: #1698